some optimizations #288
Merged
some optimizations #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // normal property verification | ||
| $this->checkUndefined($value, new \stdClass(), $path, $i); | ||
| } | ||
| //$this->checkUndefined($value, new \stdClass(), $path, $i); |
There was a problem hiding this comment.
I really don't know why this was there.. what does the comment "// normal property verification" mean?
If we have no schema at all, is there any need to continue the recursion? If I check UndefinedConstraint, all it does is always checking stuff in $schema which was an empty \stdClass() all the way - anybody knows more?
|
@narcoticfresh please rebase this on master |
narcoticfresh
force-pushed
the
feature/some-optimization
branch
from
19bff1e to
2f590d5
Compare
|
@bighappyface rebased and squashed - i also removed some things as suggested by earlier comments.. |
|
@narcoticfresh I merged a few PRs this morning and I want to be sure this wasn't affected before I merge. Would you please rebase once more? Once the tests run/pass I will merge this PR. |
narcoticfresh
force-pushed
the
feature/some-optimization
branch
from
4a0849c to
72e5066
Compare
fix wrong merge
narcoticfresh
force-pushed
the
feature/some-optimization
branch
from
4158e46 to
0015556
Compare
|
@bighappyface rebased & squashed again.. please merge ;-) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys..
this PR tries to minimize the calls done by the validation. Most is quite minor, but if you're dealing with call graphs like this (check the call numbers) - even small things matter..
I could squeeze out ~100ms out with those changes, whole request is now ~1.5s, so it saved maybe ~6-7%.. I'm still on the quest to squeeze more out, but only those were the low hanging fruits I've found..
It seems there is a certain threshold where validation is 'quite quick' - if the graph becomes quite big (like in our case); there is a continuous increase in request time. Makes sense of course..
There is something I commented out in this PR where I wasn't sure why it's even there, I'll comment it separately..